Handle stream_deleted child notification in SourceBin #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastcanal
force-pushed
the
propagate_stream_deleted
branch
from
92c5c6d to
109f664
Compare
|
Looks like this was already handled in #106 but I didn't see it before creating this PR :). I've rebased my changes to only include the failing test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I am getting a
FunctionClauseErrorinRTMP.SourceBinwhen an RTMP stream ends before the pipeline is terminated. It looks likeRTMP.SourceBinis not setup to handle the:stream_deletedchild notification.This PR:
stream_deletedchild notification fromSourcetoSourceBinby forwarding to it's parent.