Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for explicitly setting Opus bitrate and signal type. #66

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

CJRChang
Copy link
Contributor

@CJRChang CJRChang commented Jan 6, 2025

Added support for explicitly setting:

  • output bitrate
  • encoded signal type
    instead of using Opus's auto-detection.

@CJRChang CJRChang requested a review from mat-hek as a code owner January 6, 2025 05:41
Copy link
Member

@mat-hek mat-hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please make sure that tests, credo, dialyzer and mix format --check-formatted pass

lib/membrane_opus/encoder.ex Outdated Show resolved Hide resolved
@CJRChang
Copy link
Contributor Author

Confirmed credo, dialyzer and mix format --check-formatted pass.
Unfortunately tests don't currently pass on main for me (I suspect because I'm running opus 1.5.2).

Happy to update the expected output file if that's appropriate.

@mat-hek
Copy link
Member

mat-hek commented Jan 10, 2025

No need, thanks ;)

@mat-hek mat-hek merged commit 1f1d381 into membraneframework:master Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants