Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pts at the end of stream (opus) #60

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Set pts at the end of stream (opus) #60

merged 2 commits into from
Mar 11, 2024

Conversation

bartkrak
Copy link
Contributor

@bartkrak bartkrak commented Mar 6, 2024

PTS value is bumped every time encode_buffer is run.
After last encode_buffer in state there is a PTS value ready for the next buffer, that means we simply assign pts from state to the buffer that's returned from end_of_stream.

@bartkrak bartkrak requested a review from mat-hek as a code owner March 6, 2024 14:42
@bartkrak bartkrak requested a review from FelonEkonom March 6, 2024 14:43
@bartkrak bartkrak changed the title set pts on end of stream Set pts at the end of stream (opus) Mar 6, 2024
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok. Bump project version

@bartkrak bartkrak merged commit 4ea00a0 into master Mar 11, 2024
3 checks passed
@bartkrak bartkrak deleted the end_of_stream_pts branch March 11, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants