Pts integrity warn

[bartkrak]

No description provided.

[FelonEkonom]

Suggested change

	defp validate_pts_integrity(true = _check_pts_integrity?, packets, input_pts) do
	cond do
	length(packets) >= 2 and Enum.at(packets, 1).pts > input_pts ->
	Membrane.Logger.warning("PTS values are overlapping")
	length(packets) >= 2 and Enum.at(packets, 1).pts < input_pts ->
	Membrane.Logger.warning("PTS values are not continous")
	true ->
	:ok
	end
	end
	defp validate_pts_integrity(packets, input_pts) do
	cond do
	length(packets) < 2 or Enum.at(packets, 1).pts == input_pts ->
	:ok
	Enum.at(packets, 1).pts > input_pts ->
	Membrane.Logger.warning("PTS values are overlapping")
	:ok
	Enum.at(packets, 1).pts < input_pts ->
	Membrane.Logger.warning("PTS values are not continous")
	:ok
	end
	end

1. I would avoid calling length(packets) two times, because this function has linear complexity
2. Move it to Util module, to stop reapeating yourself and delete this function from Encoder
3. IMO it would be prettier to remove flag from function args and wrap function call into an if statement, eg. if check_pts_integrity?, do: Util.validate..

[FelonEkonom]

Bump version minor

[FelonEkonom]

Suggested change

	@spec validate_pts_integrity(list(), any()) :: :ok
	@spec validate_pts_integrity([Membrane.Buffer.t()], integer()) :: :ok

It is better, to be more specific in typespecs, when it is possible