Use new rtmp api #12
Merged
Use new rtmp api #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all tests pass locally, but circle ci decided to stop working. |
bartkrak
requested review from
varsill and
mat-hek
and removed request for
varsill
varsill
reviewed
Jul 23, 2024
| {:membrane_rtmp_plugin, ">= 0.0.0"}, | ||
| # {:membrane_rtmp_plugin, ">= 0.0.0"}, | ||
| {:membrane_rtmp_plugin, | ||
| github: "membraneframework/membrane_rtmp_plugin", branch: "handle_new_client"}, |
There was a problem hiding this comment.
just remember to change it once new rtmp plugin version is released ;)
mat-hek
reviewed
Jul 29, 2024
lib/boombox/rtmp.ex
Outdated
Comment on lines
9
to
10
| @type state :: %{server_pid: pid()} | nil | ||
|
|
There was a problem hiding this comment.
Suggested change
| @type state :: %{server_pid: pid()} | nil |
lib/boombox/rtmp.ex
Outdated
| alias Boombox.Pipeline.{Ready, Wait} | ||
| alias Membrane.RTMP.Utils |
There was a problem hiding this comment.
Name Utils is a bit ambiguous, I'd just alias Membrane.RTMP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rtmp api added in membraneframework/membrane_rtmp_plugin#94 - not merged yet