Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Require urllib3 < 2 on Python < 3.10 #2821

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 4, 2025

@edgarrmondragon edgarrmondragon self-assigned this Jan 4, 2025
@edgarrmondragon edgarrmondragon added this to the v0.44 milestone Jan 4, 2025
Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #2821 will not alter performance

Comparing edgarrmondragon/packaging/require-urllib-1-py39 (7f325a9) with main (2d75501)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (2d75501) to head (7f325a9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2821   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          62       62           
  Lines        5190     5190           
  Branches      669      669           
=======================================
  Hits         4738     4738           
  Misses        319      319           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 5, 2025 18:42
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner January 5, 2025 18:42
@edgarrmondragon edgarrmondragon merged commit 3c29a96 into main Jan 5, 2025
34 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/packaging/require-urllib-1-py39 branch January 5, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant