Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SHA256 encryption method to inline stream maps #2819

Merged
merged 7 commits into from
Dec 27, 2024

Conversation

ben-schulz-mh
Copy link
Contributor

@ben-schulz-mh ben-schulz-mh commented Dec 27, 2024

Implements #2818


📚 Documentation preview 📚: https://meltano-sdk--2819.org.readthedocs.build/en/2819/

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #2819 will not alter performance

Comparing ben-schulz-mh:patch-1 (a670818) with main (920d630)

Summary

✅ 7 untouched benchmarks

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (920d630) to head (a670818).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2819   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          62       62           
  Lines        5190     5190           
  Branches      669      669           
=======================================
  Hits         4738     4738           
  Misses        319      319           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ben-schulz-mh ben-schulz-mh marked this pull request as ready for review December 27, 2024 03:36
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ben-schulz-mh!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Dec 27, 2024
Merged via the queue into meltano:main with commit 8a0421b Dec 27, 2024
31 checks passed
@edgarrmondragon edgarrmondragon added this to the v0.44 milestone Dec 28, 2024
@ben-schulz-mh
Copy link
Contributor Author

Thanks for your generous help @edgarrmondragon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add SHA256 encryption method
2 participants