Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Benchmarks for record datetime parsing #2054

Conversation

BuzzCutNorman
Copy link
Contributor

@BuzzCutNorman BuzzCutNorman commented Nov 17, 2023

Closes #2048


📚 Documentation preview 📚: https://meltano-sdk--2054.org.readthedocs.build/en/2054/

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f96df37) 87.46% compared to head (b5eb24e) 87.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          58       58           
  Lines        4867     4867           
  Branches      993      993           
=======================================
  Hits         4257     4257           
  Misses        429      429           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BuzzCutNorman
Copy link
Contributor Author

@edgarrmondragon I am not quite sure why test_validate_record is passing while test_bench_parse_timestamps_in_record and test_bench_validate_and_parse are failing. I would think all three would pass or fail the same way. When you have some time would you please review the codspeed errors.

Copy link

codspeed-hq bot commented Nov 20, 2023

CodSpeed Performance Report

Merging #2054 will not alter performance

Comparing BuzzCutNorman:2048-benchmarks-for-datetime-parsing (b5eb24e) with main (f96df37)

Summary

✅ 1 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main BuzzCutNorman:2048-benchmarks-for-datetime-parsing Change
🆕 test_bench_parse_timestamps_in_record N/A 25.2 s N/A
🆕 test_bench_validate_and_parse N/A 29.7 s N/A

@BuzzCutNorman BuzzCutNorman marked this pull request as ready for review November 20, 2023 16:31
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot @BuzzCutNorman!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Nov 22, 2023
Merged via the queue into meltano:main with commit 4cc52db Nov 22, 2023
27 checks passed
@BuzzCutNorman BuzzCutNorman deleted the 2048-benchmarks-for-datetime-parsing branch November 28, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Set up benchmarks for record and/or datetime parsing
2 participants