Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Benchmark for record schema validation #2053

Conversation

BuzzCutNorman
Copy link
Contributor

@BuzzCutNorman BuzzCutNorman commented Nov 17, 2023

Closes #2047


📚 Documentation preview 📚: https://meltano-sdk--2053.org.readthedocs.build/en/2053/

Copy link

codspeed-hq bot commented Nov 17, 2023

CodSpeed Performance Report

Merging #2053 will not alter performance

Comparing BuzzCutNorman:2047-benchmark-jsonschema-record-validation (8142adb) with main (839fe6e)

Summary

✅ 3 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main BuzzCutNorman:2047-benchmark-jsonschema-record-validation Change
🆕 test_bench_validate_record_with_schema N/A 455.5 ms N/A

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (839fe6e) 87.48% compared to head (8142adb) 87.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2053   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          58       58           
  Lines        4875     4875           
  Branches      993      993           
=======================================
  Hits         4265     4265           
  Misses        429      429           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BuzzCutNorman BuzzCutNorman marked this pull request as ready for review November 17, 2023 23:21
@edgarrmondragon edgarrmondragon changed the title test: benchmark for record validation with schema test: Benchmark for record schema validation Nov 22, 2023
@edgarrmondragon edgarrmondragon added this pull request to the merge queue Nov 22, 2023
Merged via the queue into meltano:main with commit 38d2ec2 Nov 22, 2023
27 checks passed
@BuzzCutNorman BuzzCutNorman deleted the 2047-benchmark-jsonschema-record-validation branch November 28, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Set up benchmarks for record schema validation
2 participants