-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(taps): Add benchmark test on map transforms via pytest-benchmark
#2011
Conversation
6037938
to
f541e64
Compare
54c5175
to
e8032dd
Compare
@edgarrmondragon I added the benchmark test, but having some trouble with the github action to post the benchmark result as a comment on the PR for now, am removing the gh action to try to comment on the PR |
22c3214
to
28da357
Compare
Codecov Report
@@ Coverage Diff @@
## main #2011 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 59 59
Lines 5136 5136
Branches 830 830
=======================================
Hits 4490 4490
Misses 451 451
Partials 195 195 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
95702e8
to
28da357
Compare
Thank you so much for the contribution @haleemur! I think this is good enough as a first iteration. I think I can integrate Codspeed with very minor changes to comment in PRs. |
pytest-benchmark
relates to #2002.
As suggested in #2002 (comment),
This PR adds a benchmark test using pytest-benchmark to test the performance of stream maps using simpleeval, and ensure that we do not harm application performance by using
EvalWithCompoundTypes
.The PR does the following:
_run_transform
out of_test_transform
to use for benchmarkingrepositories
stream with stream size of 4000 recordspytest-benchmark
as a development dependencybenches
)I'm less sure if I've implemented the following two correctly as I'm not familiar with github actions
📚 Documentation preview 📚: https://meltano-sdk--2011.org.readthedocs.build/en/2011/