fix(target): DDL for adding a column now uses a SQLAlchemy-compiled c…

…lause to apply proper quoting (#2582) compile create column clause with sqla engine to ensure proper quoting is applied Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
meltano · Aug 1, 2024 · 7ccfb87 · 7ccfb87
1 parent b5ed825
commit 7ccfb87
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py
@@ -974,8 +974,8 @@ def _get_column_type(
 
         return column.type
 
-    @staticmethod
     def get_column_add_ddl(
+        self,
         table_name: str,
         column_name: str,
         column_type: sa.types.TypeEngine,
@@ -998,11 +998,12 @@ def get_column_add_ddl(
                 column_type,
             ),
         )
+        compiled = create_column_clause.compile(self._engine)
         return sa.DDL(
             "ALTER TABLE %(table_name)s ADD COLUMN %(create_column_clause)s",
-            {
+            {  # type: ignore[arg-type]
                 "table_name": table_name,
-                "create_column_clause": create_column_clause,
+                "create_column_clause": compiled,
             },
         )