Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697.
There is no good reason to export both
$$default
(asdefault
is reserved word) anddefault
, this leads to all sorts of issues with JS tooling.The PR removes the former from the named outputs, allowing Melange users to export just the
default
value.It is a breaking change, so maybe can be included in v2?
See both outputs in rollup repl, with both exports (notice the warning) and just the default.
For reference, this is the PR when the
default
handling was introduced, unfortunately there's not a lot of context or information about it: rescript-lang/rescript-compiler#2002.