Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove warnings, part 1 #701

Merged
merged 2 commits into from
Nov 25, 2023
Merged

docs: remove warnings, part 1 #701

merged 2 commits into from
Nov 25, 2023

Conversation

jchavarri
Copy link
Member

Part of #693.

Still a long way to go, there are lots of other warnings in compiler libs, e.g.

File "vendor/melange-compiler-libs/lib/parse.mli", line 87, characters 29-43:
Warning: Failed to resolve reference unresolvedroot(Longident).t Couldn't find "Longident"

And also in melange itself, due to the way Js_internal is included I believe:

Warning, resolved hidden path: Js__.Js_internal.Fn.arity2

There are also other warnings that I have no clue how to solve about alerts, e.g.:

File "jscomp/stdlib/moreLabels.mli", line 63, character 2 to line 65, character 3:
Warning: Alert unsynchronized_access not expected here.

But this PR already includes some fixes, maybe can be considered to merge to keep doing progressive improvements.

jscomp/ext/ext_array.mli Outdated Show resolved Hide resolved
@anmonteiro
Copy link
Member

@anmonteiro anmonteiro merged commit e0348fc into main Nov 25, 2023
4 checks passed
@anmonteiro anmonteiro deleted the improve-docs-1 branch November 25, 2023 02:20
@jchavarri
Copy link
Member Author

thank you sir 🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants