Skip to content

Commit

Permalink
add opam-check-npm-deps (#23)
Browse files Browse the repository at this point in the history
* add opam-check-npm-deps

* fix ci

* downgrade version of react to match reason-react depexts
  • Loading branch information
jchavarri authored Sep 8, 2023
1 parent f2dd8dc commit f5b9db7
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 17 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ install: ## Install development dependencies
opam update
opam install -y . --deps-only
opam pin -y add $(project_name).dev .
opam exec opam-check-npm-deps

.PHONY: build
build: ## Build the project
Expand Down
1 change: 1 addition & 0 deletions melange-opam-template.opam
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ depends: [
"melange" {>= "1.0.0"}
"reactjs-jsx-ppx" {>= "1.0.0"}
"reason-react" {>= "0.11.0"}
"opam-check-npm-deps" {dev} # todo: use with-dev-setup once 2.2 is out
"ocaml-lsp-server" {dev}
"dot-merlin-reader" {dev}
"odoc" {with-doc}
Expand Down
41 changes: 26 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"serve": "webpack serve --open --mode development --entry ./_build/default/src/output/src/ReactApp.js"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^17.0.0",
"react-dom": "^17.0.0"
},
"devDependencies": {
"webpack": "^5.73.0",
Expand Down

0 comments on commit f5b9db7

Please sign in to comment.