Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSC-329: Set Numéro Dossier as primary identifier #17

Merged
merged 2 commits into from
Oct 15, 2024
Merged

HSC-329: Set Numéro Dossier as primary identifier #17

merged 2 commits into from
Oct 15, 2024

Conversation

kazlaw
Copy link
Contributor

@kazlaw kazlaw commented Oct 11, 2024

@kazlaw
Copy link
Contributor Author

kazlaw commented Oct 11, 2024 •
edited
Loading

image

image

image

image

@kazlaw kazlaw marked this pull request as ready for review October 11, 2024 09:47
@kazlaw kazlaw requested review from Ruhanga and rbuisson and removed request for Ruhanga October 11, 2024 09:48
@rbuisson rbuisson changed the title HSC-329:Set Numéro Dossier as Primary Identifier for the Patient Identifier Sticker HSC-329: Set Numéro Dossier as primary identifier Oct 11, 2024
rbuisson
rbuisson reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@rbuisson rbuisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the primary vs extra patient identifiers are set via metadatatermmappings and not via the global properties?

@kazlaw
Copy link
Contributor Author

kazlaw commented Oct 14, 2024

So the primary vs extra patient identifiers are set via metadatatermmappings and not via the global properties?

@rbuisson the metadatatermmappings domain is presented that way from the RefApp the extra identifiers were setup through the normal csv files.

Cc: @Ruhanga

@rbuisson
Copy link
Member

rbuisson commented Oct 14, 2024 •
edited
Loading

OK good. I guess what I had in mind was this, but then it is obviously Bahmni-specific.

@kazlaw kazlaw requested a review from rbuisson October 15, 2024 09:54
rbuisson
rbuisson approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@rbuisson rbuisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazlaw kazlaw merged commit bfe0d81 into mekomsolutions:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuisson rbuisson rbuisson approved these changes

@Ruhanga Ruhanga Awaiting requested review from Ruhanga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazlaw @rbuisson