-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MekaTool Radial Profiles #7471
base: 1.18.x
Are you sure you want to change the base?
MekaTool Radial Profiles #7471
Conversation
6 seems a good number to me, and we could maybe use the handle mode key to open the menu instead of switching modes if it'll just be obsolete. |
To clarify the handle mode key option previously decided if trying to change the mode would change the mode on that module, the key itself is still being used for the radial menu, but it can change the mode for any config. What I was suggesting possibly removing was just the boolean on the module to say whether it handled the key. The NBT profiles are currently on the itemstacks, which is also where the module data is, if you switched to a different mekatool it could have different modules/configs/profiles. I don't think we'd want that to be global, even though the profile names are currently. |
I see what you mean now, and I definitely agree. You're probably right about radial wheels being NBT not global as well |
Show me <: |
minecraft-1182-singleplayer-2022-05-07-13-40-25-xisvz1or-ygwc47bp_Ax91Gc9x.mp4 |
I think everything is resolved on this except for the static mode names. I don't see a way to fix that so I think it's done unless someone else can think of something. |
c03dc4c
to
f6edc72
Compare
f6edc72
to
567ca32
Compare
Rebased, cleaned up, and squashed. Squashed commits: MekaTool radial profiles kinda working, more GUI work needed Added packet to save mekatool profile, save client config, gui fixes Small changes to the enum Added profile hud string and removed handle mode key from efficiency module
567ca32
to
6525af2
Compare
Changes proposed in this pull request:
So I got this idea from Mekanism-Feature-Requests#282
It is mostly working and it is awesome to use.
Currently limited to 6 profiles and while it has to be hardcoded to be in the enum there is no reason there couldn't be more, and potentially even disable them based on a numeric property
That being said there are issues with how I did it that probably need to be fixed.
The server sync kinda just piggybacks off of the module.save currently which works, but isn't ideal.
It's currently dealing with the NBT directly instead of using the config.set methods so that the module.save doesn't overwrite it, I have some potential solutions in mind, but I'm not sure which way would be best.
It only saves an option which you have changed while on that profile. Which if there was a way to clear a profile could actually be a feature.
The save button in the GUI doesn't do anything right now.
The profile names can be changed with the GUI, but it's static so it's the same for every MekaTool.
This also kinda makes the handle mode key option on the tool modules obsolete. So we might want to remove that on them.