Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): Inefficient Regular Expression Complexity in nth-check #514

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(security): Inefficient Regular Expression Complexity in nth-check #514

merged 1 commit into from
May 14, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented May 14, 2024

Pull Request

What does this PR do?

The nth-check package is used by css-select which is also used by react-script, not maintained anymore.
This PR forces the use of the latest nth-check version containing the vulnerability fix

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added dependencies Pull requests that update a dependency file skip-changelog security Pull requests that address a security vulnerability labels May 14, 2024
@mdubus mdubus requested a review from curquiza May 14, 2024 13:26
curquiza
curquiza approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 14, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 6f3db3d into main May 14, 2024
5 checks passed
@meili-bors meili-bors bot deleted the fix_nth_check_vulerability branch May 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @curquiza