Distinct attribute at search time #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
requested changes
Jul 6, 2024
There was a problem hiding this comment.
hello @zxcq544
Thank you for your PR
Two important things to fix before merging
- Not the full issue has been implemented. Can you implement the third point of the issue about code-samples?
- The test of our CI do not pass. Can you run them locally and fix them? The steps are described in our CONTRIBUTING.md
|
Done. |
|
Fixed YAML linting. I think it's done now :) |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #547
What does this PR do?
distinctattribute at search time.distinctattribute at search time.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!