Backport PR spacetelescope#137: improve initial scatter/mouseover per…

…formance (spacetelescope#138) Co-authored-by: Kyle Conroy <[email protected]>
meeseeksmachine · Sep 5, 2024 · 9e204bd · 9e204bd
1 parent 7e691b7
commit 9e204bd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -3,6 +3,8 @@
 
 * bumps lightkurve to 2.5.0 to include upstream bug fixes. [#132]
 
+* Improve scatter viewer and mouseover performance. [#137]
+
 
 0.4.2 (07.23.2024)
 ------------------

diff --git a/lcviz/plugins/coords_info/coords_info.py b/lcviz/plugins/coords_info/coords_info.py
@@ -89,10 +89,7 @@ def _cursor_fallback():
             if self.dataset.selected != 'auto' and self.dataset.selected != lyr.layer.label:
                 continue
 
-            # glue-jupyter 1.18 changed from lyr.scatter to lyr.scatter_mark
-            # TODO: once glue-jupyter is pinned to 1.18 or later, update this to:
-            # scatter = lyr.scatter_mark
-            scatter = getattr(lyr, 'scatter_mark', getattr(lyr, 'scatter', None))
+            scatter = lyr.scatter_mark
             lyr_x, lyr_y = scatter.x, scatter.y
             if not len(lyr_x):
                 continue

diff --git a/lcviz/viewers.py b/lcviz/viewers.py
@@ -149,6 +149,7 @@ def _apply_layer_defaults(self, layer_state):
         if getattr(layer_state.layer, 'meta', {}).get('Plugin', None) == 'Binning':
             # increased size of binned results, by default
             layer_state.size = 5
+        layer_state.points_mode = 'markers'
 
     def set_plot_axes(self):
         # set which components should be plotted
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,6 +3,8 @@ @@
     * bumps lightkurve to 2.5.0 to include upstream bug fixes. [#132]
+    * Improve scatter viewer and mouseover performance. [#137]
 .4.2 (07.23.2024)
     ------------------
@@ Expand Down @@