-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script interface instead of cli tool. BREAKING #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…51x3OUz2CdA directory
nhz2
changed the title
Script interface.
Make script interface instead of cli tool. BREAKING
Oct 3, 2023
nhz2
changed the title
Make script interface instead of cli tool. BREAKING
Script interface instead of cli tool. BREAKING
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete redo of how MEDYANSimRunner is used. Before, it was installed as a command line tool. Now it is just a regular Julia package inspired by how build scripts work in BinaryBuilder.jl.
To upgrade inputs to this new version do the following:
import MEDYANSimRunner
to the start ofmain.jl
and addMEDYANSimRunner
to the input environment.main.jl
, for example,jobs = ["a", "b", "c",]
. This should contain what used to be injobnames.txt
.abspath(PROGRAM_FILE) == @__FILE__ && MEDYANSimRunner.run_sim(ARGS; jobs, setup, loop, load_snapshot, save_snapshot, done)
to the very end ofmain.jl
To run the simulation, instead of:
Do:
The output of the simulation is also very different. There is no more
list.txt
. Instead extra metadata has been added to each snapshot, which is now stored in thetraj
output subdirectory insnap$(step).zarr.zip
files, along withheader.json
and a newfooter.json
. Because of this extra metadata, theZGroup
returned bysave_snapshot
which used to be the root of thesnap$(step).zarr.zip
files has been moved to the "snap" subgroup.