Fix saml_idp_sso_binding_urn selection logic in update_from_saml_meta…

…data()
medusa-project · Mar 5, 2024 · 2ff8c3b · 2ff8c3b
1 parent ef364ed
commit 2ff8c3b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/models/institution.rb b/app/models/institution.rb
@@ -807,7 +807,8 @@ def update_from_saml_metadata(metadata_xml_file)
           self.saml_idp_sso_post_service_url = node.attr("Location")
         end
       end
-      if self.saml_idp_sso_binding_urn.blank?
+      if (self.saml_idp_sso_redirect_service_url.blank? || self.saml_idp_sso_post_service_url.blank?) ||
+          self.saml_idp_sso_binding_urn.blank?
         self.saml_idp_sso_binding_urn = self.saml_idp_sso_redirect_service_url.present? ?
                                           "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" :
                                           "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"