/explore #55
Draft
/explore #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aofn
commented
Sep 6, 2023
•
aofn
commented
- if selectedSpaceChildren length is 1 check for parent in matrix
- check if rooms/spaces are already in our matrix storage and only then use roomHierarchy
- check if user actually has the needed power level to invite users to the matrix room (s. this)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| isSubscribed = false; | ||
| }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [matrixClient, parentSpaceRoomId, sortAlphabetically, templatePlaceholderMapping, templatePrefixFilter]); |
Check failure
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Error
There was a problem hiding this comment.
ESLint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
fnwbr
requested changes
Jan 31, 2024
| return () => { | ||
| cancelled = true; | ||
| }; | ||
| }, [router.query?.roomId, matrix.initialSyncDone, cachedSpace]); |
Check failure
Code scanning / ESLint
verifies the list of dependencies for Hooks like useEffect and similar Error
…s-spaces into explore
…s-spaces into explore
…view /explore: fix icons in context view
/explore: conditional loading
…h-defaultoption adding default value and remove error for `template select`
for reference: abaece4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.