Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#9653): refactor shared-libs/validations to call cht-datasource #9755

Open
wants to merge 2 commits into
base: 9586-implement-freetext-search-in-cht-datasource
Choose a base branch
from

Conversation

sugat009
Copy link
Member

@sugat009 sugat009 commented Jan 22, 2025

Description

Refactored the shared-libs/validations library to query cht-datasource when possible while still querying freetext indexes for when there is whitespace in the freetext search string.

Ticket: #9653

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@sugat009 sugat009 requested a review from jkuester January 22, 2025 15:57
@sugat009
Copy link
Member Author

I've set the target branch to 9586-implement-freetext-search-in-cht-datasource because it has not been merged to master yet and will show lots of diffs.

@sugat009
Copy link
Member Author

@jkuester I've not added an actual e2e test for this one because the unit tests feel like integration tests for the whole package. Let me know what you think though.

@sugat009 sugat009 changed the title feat(#9653): refactor shared-libs/validations to call cht-datasource instead of querying freetext indexes feat(#9653): refactor shared-libs/validations to call cht-datasource Jan 22, 2025
@jkuester
Copy link
Contributor

I don't think we need integration tests specific to shared-libs/validations. However, if it is possible it would be good to have at least one sentinel integration test that triggers this validation code (basically validating the overall workflow that users the validations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants