Improve re-render checking using memo in TransitionPresence #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch to `memo` didn't work out since it would block too much rendering when updating other props (or children) of the children passed to the TransitionPresence. A story is added for the above scenario, so we won't make the same mistake in the future. Some comments and logging is added since this component will receive other updates shortly.
ThaNarie
force-pushed
the
feature/92-use-memo-for-children-equality-check
branch
from
92c51e9 to
52af025
Compare
|
Closing this PR because it's not needed with the changes from #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve rerender checks in TransitionPresence
The switch to
memodidn't work out since it would block too muchrendering when updating other props (or children) of the children passed
to the TransitionPresence.
A story is added for the above scenario, so we won't make the same
mistake in the future.
Some comments and logging is added since this component will receive
other updates shortly.
#92