Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#185 create useIntersectionObserver hook #224

Merged
merged 8 commits into from
Oct 13, 2023
Merged

#185 create useIntersectionObserver hook #224

merged 8 commits into from
Oct 13, 2023

Conversation

petervdn
Copy link
Contributor

Not sure what to do with the .test.ts, i removed it since the IntersectionObserver API is only available in the browser.

@petervdn petervdn linked an issue Aug 22, 2023 that may be closed by this pull request
Create useIntersectionObserver hook #185
Closed
@leroykorterink leroykorterink changed the title 185 create useintersectionobserver hook #185 create useIntersectionObserver hook Aug 23, 2023
@leroykorterink
Copy link
Collaborator

leroykorterink commented Aug 23, 2023 •
edited
Loading

Not sure what to do with the .test.ts, i removed it since the IntersectionObserver API is only available in the browser.

@petervdn we can create tests using playwright, see useMediaQuery.playwright.tsx as an example of how to write playwright tests for hooks.

Added play tests

@leroykorterink leroykorterink added enhancement New feature or request documentation Improvements or additions to documentation labels Aug 23, 2023
@leroykorterink leroykorterink merged commit 60e74a6 into main Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leroykorterink leroykorterink leroykorterink approved these changes

@ThaNarie ThaNarie Awaiting requested review from ThaNarie

@VictorGa VictorGa Awaiting requested review from VictorGa

@larsvanbraam larsvanbraam Awaiting requested review from larsvanbraam

@jesse-mm jesse-mm Awaiting requested review from jesse-mm

@hjeti hjeti Awaiting requested review from hjeti

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create useIntersectionObserver hook
3 participants
@petervdn @leroykorterink @kevin-van-helden