feat: adding custom blocks test #4
Conversation
|
Hi @subhendukundu , thanks for the addition, would you be able to add unit test fixtures for this as well? :) |
|
@ThaNarie , I have added the test cases, let me know what do you think? |
|
Are we merging this anytime soon? |
| @@ -0,0 +1 @@ | |||
| <sly data-sly-test="${ author }"><h2>By ${ firstName } ${ lastName }</h2></sly> | |||
There was a problem hiding this comment.
It this correct? In hbs the name fields are nested within the with block, so without changing scope in htl, shouldn't it be author.firstName ?
| @@ -0,0 +1 @@ | |||
| <sly data-sly-test="${ foo == 'false' }">Foo</sly> | |||
There was a problem hiding this comment.
Shouldn't it be false as a boolean, currently you're comparing it to a string?
| @@ -0,0 +1 @@ | |||
| {{#gt noListItems 1}}<h2>Greater</h2>{{/gt}} | |||
There was a problem hiding this comment.
Do we need a dedicated custom helper for this?
In Muban we have https://github.com/mediamonks/muban/blob/master/build-tools/handlebars-helpers/condition.js, where you can use all condition types. Does > work in htl in a -test check?
| @@ -0,0 +1 @@ | |||
| {{#is noListItems 1}}Foo{{/is}} | |||
There was a problem hiding this comment.
Adding this custom block-helpers, as well inbuilt helpers like
#withfor handlebars.