Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ESLint flat config setup #258

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

leroykorterink
Copy link
Collaborator

No description provided.

@leroykorterink leroykorterink requested a review from ThaNarie May 28, 2024 08:59
@leroykorterink leroykorterink self-assigned this May 28, 2024
@leroykorterink
Copy link
Collaborator Author

I decided to not change the package setup right now, because we need to merge all dependencies to one package which could cause some dependencies to be unused when for example only the configuration for JavaScript is used.

What are your thoughts on merging everything in one package @ThaNarie?

@leroykorterink leroykorterink added enhancement New feature or request question Further information is requested labels May 28, 2024
@leroykorterink leroykorterink marked this pull request as ready for review November 8, 2024 10:32
@leroykorterink
Copy link
Collaborator Author

Merging the packages simplifies the setup and package management and most projects use typescript anyway so I believe this is a much better strategy

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Comment on lines +24 to +26
"exports": {
".": "./src/index.js"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also export the non-index files, which might make it easier to construct your own presets from these building blocks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind but it also encourages creating custom presets. We can just re-export the rules from the index.js file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also works for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants