Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration:
I'm trying to clean my repo of half-finished project branches.
Turned on additional mypy knobs, the most significant is
disallow_any_generics
which disallows bare use of List, Dict, Callable, Generator.Added stubs/rabbitmq_admin.pyi for untyped library.
Eliminated some existing mypy complaints (due to newer versions of mypy on files that haven't changed?)
Added 3 more
type: ignore
comments (all Scrapy related), new total is 9, which doesn't seem excessive.and added 13 more lines with
Any
new total in non-tests code: 42, located in in the following files:My guess is that a lot of the use of Any is due to reading JSON files, or dealing with untyped libraries, and several due to exit method definitions that don't care about the arguments!