Add extension group support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really like this implementation. A nicer one would get the fields for the target struct and create a list instead of just a reference (same for the extension base). But I wasn't sure how to reach that so if you have any suggestions, it's welcome. Maybe a two-pass implementation? |
|
@MarcAntoine-Arnaud do you think there's any path to get this merged? If not, could you please comment on what adjustments I should make. |
MarcAntoine-Arnaud
approved these changes
Jan 2, 2024
|
Sorry more time was needed to understand your code. Thank you ! |
|
Sorry my comment was not meant as pressure - I just wanted to get a rough idea. |
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3
Still missing "all" and "choice" (#20).