Add a is_string check to the params iterator (woocommerce#52361)

This works fine: ``` curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?_unstable_tax_asdf_operator=1" | jq ``` However, this causes a fatal error `PHP Fatal error: Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, int given`: ``` curl -u bor0:asdf -X OPTIONS "localhost:8080/wp-json/wc/store/v1/products?1=2" | jq ```
medavidallsop · Oct 28, 2024 · 1f0dc7a · 1f0dc7a
1 parent 0b56f7e
commit 1f0dc7a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/plugins/woocommerce/changelog/fix-fatal-error-storeapi b/plugins/woocommerce/changelog/fix-fatal-error-storeapi
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Fix StoreAPI erroring when a param is an integer
diff --git a/plugins/woocommerce/src/StoreApi/Routes/V1/Products.php b/plugins/woocommerce/src/StoreApi/Routes/V1/Products.php
@@ -301,6 +301,10 @@ public function get_collection_params() {
 
 		// If the $_REQUEST contains a taxonomy query, add it to the params and sanitize it.
 		foreach ( $_REQUEST as $param => $value ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+			if ( ! is_string( $param ) ) {
+				continue;
+			}
+
 			if ( str_starts_with( $param, '_unstable_tax_' ) && ! str_ends_with( $param, '_operator' ) ) {
 				$params[ $param ] = array(
 					'description'       => __( 'Limit result set to products assigned a specific category ID.', 'woocommerce' ),