Fix Deprecation Warning and Resolve Minor Issues

README.md

@@ -64,7 +64,7 @@ the transaction data from Bitcoin Core RPC server.
 ```ts
 import {
   tryDecodeRunestone,
-  isRunestoneArtifact,
+  isRunestone,
   RunestoneSpec,
   Cenotaph
 } from '@magiceden-oss/runestone-lib';

src/indexer/types.ts

@@ -50,7 +50,7 @@ export interface RunestoneStorage {
 
   /**
    * Get the total valid mint counts for rune up to and including specified block height.
-   * @param rune rune id string representation
+   * @param runeLocation rune id string representation
    * @param blockheight block height to count up to
    */
   getValidMintCount(runeLocation: string, blockheight: number): Promise<number>;

src/runestone.ts

@@ -250,7 +250,6 @@ export class Runestone {
     stack.push(MAGIC_NUMBER);
 
     const payload = Buffer.concat(payloads);
-    let i = 0;
     for (let i = 0; i < payload.length; i += MAX_SCRIPT_ELEMENT_SIZE) {
       stack.push(payload.subarray(i, i + MAX_SCRIPT_ELEMENT_SIZE));
     }

src/script.ts

@@ -291,7 +291,7 @@ export namespace script {
         // attempt to read too much data?
         if (i + d.number > buffer.length) return false;
 
-        const data = buffer.slice(i, i + d.number);
+        const data = buffer.subarray(i, i + d.number);
         i += d.number;
 
         yield data;

src/utils.ts

@@ -1,4 +1,4 @@
-import { script, opcodes } from './script';
+import { script } from './script';
 
 export namespace Instruction {
   export function isNumber(instruction: script.Instruction): instruction is number {