Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more explicit checking of uint types and better artifact type check #62

Merged
merged 1 commit into from
May 9, 2024
Merged

Added more explicit checking of uint types and better artifact type check #62

merged 1 commit into from
May 9, 2024

Conversation

summraznboi
Copy link
Collaborator

  • Fixed uint types to only allow valid and supported values (bigints and safe integer numbers within range)
  • Changed internal isRunestone check to use type property with runestone or cenotaph instead

@summraznboi summraznboi merged commit b604887 into main May 9, 2024
1 check passed
@summraznboi summraznboi deleted the security-review-feedback branch May 9, 2024 21:06
tansanDOTeth added a commit to tansanDOTeth/runestone-lib that referenced this pull request Jun 30, 2024
@tansanDOTeth
Revert "Added more explicit checking of uint types and better artifac…
922e0dd 
…t type check (me-foundation#62)"

This reverts commit b604887.
dcorral added a commit to dcorral/runestone-lib that referenced this pull request Jul 22, 2024
@dcorral
Revert "Added more explicit checking of uint types and better artifac…
2ac388d 
…t type check (me-foundation#62)"

This reverts commit b604887.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-rob me-rob me-rob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summraznboi @me-rob