feat: add value field to RuneUtxoBalance #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summraznboi
reviewed
May 9, 2024
src/indexer/types.ts
Outdated
| @@ -101,6 +101,7 @@ export type RuneSpentUtxoBalance = RuneUtxoBalance & { spentTxid: string }; | |||
| export type RuneUtxoBalance = { | |||
| txid: string; | |||
| vout: number; | |||
| value?: number; | |||
There was a problem hiding this comment.
This shouldn't be optional, there is always a value associated. Also, please rename to satValue, just to further disambiguate from amount that represents the rune count.
summraznboi
reviewed
May 11, 2024
src/indexer/updater.ts
Outdated
| @@ -32,7 +32,7 @@ function isScriptPubKeyHexOpReturn(scriptPubKeyHex: string) { | |||
| export type UpdaterTx = { | |||
| txid: string; | |||
| vin: ({ txid: string; vout: number; txinwitness: string[] } | { coinbase: string })[]; | |||
| vout: { scriptPubKey: { hex: string; address?: string } }[]; | |||
| vout: { scriptPubKey: { hex: string; address?: string }, value?: number }[]; | |||
There was a problem hiding this comment.
Note UpdaterTx is just a view of Tx from rpcclient of the fields needed, and value is a required field. Thus I'd make value required here too.
summraznboi
approved these changes
May 14, 2024
dcorral
pushed a commit
to ordzaar/runestone-lib
that referenced
this pull request
Sep 10, 2024
* feat: add value field to RuneUtxoBalance * fix: fix value to satValue in RuneUtxoBalance * fix: fix test/updater.test.ts for utxoBalance * fix: make value is a required field * fix: fix update.test.ts for value --------- Co-authored-by: KyleO_O <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add value field to RuneUtxoBalance