GitHub actions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcarres-mdsol @ykitamura-mdsol, please review. |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: [ ubuntu-latest ] |
There was a problem hiding this comment.
not running on self-hosted?
Suggested change
| runs-on: [ ubuntu-latest ] | |
| runs-on: [ self-hosted, ubuntu-latest ] |
There was a problem hiding this comment.
please see my answer below
|
|
||
| jobs: | ||
| verify: | ||
| runs-on: [ ubuntu-latest ] |
There was a problem hiding this comment.
Suggested change
| runs-on: [ ubuntu-latest ] | |
| runs-on: [ self-hosted, ubuntu-latest ] |
There was a problem hiding this comment.
I intentionally did it. The repository is public, so sooner or later, third-party participants' code can be run here. I don't think their GitHub Actions should be allowed to run in our cloud.
ykitamura-mdsol
approved these changes
Jul 10, 2024
| args: --verbose --concurrency=2 --timeout=600s | ||
|
|
||
| - name: Test with the Go CLI | ||
| run: go test -v ./... |
There was a problem hiding this comment.
there are no test files (yet) but I'm sure you have a plan to add them 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two GHA workflows:
ci, which runs lint/test/build on push;build_artifact, which builds new binary on new tags/releases (it is expected that the artifact will be attached to the release.