refactor: move to automated checks #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mds1
force-pushed
the
refactor/automated
branch
from
467c349 to
6ebc8d8
Compare
mds1
force-pushed
the
refactor/automated
branch
from
3578df6 to
2aa413e
Compare
fvictorio
reviewed
May 17, 2024
| return true; // Call succeeded so opcode is supported. | ||
| } catch (e: unknown) { | ||
| const err = e as CallError; | ||
| // TODO These might be specific to the node implementation, can this be more robust? |
There was a problem hiding this comment.
Maybe each opcode has to have an accompanying test case that succeeds when executed?
It's extra work, but much more robust. Happy to help with that if you think it's a good idea.
There was a problem hiding this comment.
I agree this is a good idea. I'm just about ready to merge this branch and hope to merge it early this week, so I've created #67 to track. Definitely would appreciate your help on this!
This was referenced May 17, 2024
This was referenced May 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.