Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raising error when the surface is not completely embedded inside FFDS. #181

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArshSaja
Copy link
Contributor

@ArshSaja ArshSaja commented Feb 2, 2023

Purpose

DvGeo prints a warning when it cannot embed points. So that people understand not to proceed, this warning has to be strengthened. This PR will assist in identifying any such problems.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ArshSaja ArshSaja requested a review from a team as a code owner February 2, 2023 18:43
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #181 (706585c) into main (94909eb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   64.61%   64.60%   -0.01%     
==========================================
  Files          47       47              
  Lines       11954    11952       -2     
==========================================
- Hits         7724     7722       -2     
  Misses       4230     4230              
Impacted Files Coverage Δ
pygeo/mphys/mphys_dvgeo.py 0.00% <ø> (ø)
pygeo/parameterization/DVGeoSketch.py 67.92% <ø> (-0.30%) ⬇️
pygeo/parameterization/DVGeoVSP.py 81.50% <ø> (-0.05%) ⬇️
pygeo/pyBlock.py 46.92% <0.00%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil mentioned this pull request Feb 3, 2023
13 tasks
@anilyil
Copy link
Contributor

anilyil commented Feb 3, 2023

Please see my comments in #179

@marcomangano
Copy link
Contributor

What is the status of this PR? @ArshSaja are you going to address @anilyil comments about additional checks?

@ArshSaja
Copy link
Contributor Author

@marcomangano Yes, I am planning to address them next week or so.. probably I will get it done soon

@anilyil anilyil marked this pull request as draft March 6, 2023 15:44
@eirikurj
Copy link
Contributor

@ArshSaja any updates on this?

@ArshSaja
Copy link
Contributor Author

@ArshSaja any updates on this?

I made some changes. I will push them soon when it is finalized.

@lamkina
Copy link
Contributor

lamkina commented Oct 15, 2024

@ArshSaja do you still intend to finish this PR? Seems this has gone stale over the past year.

@ArshSaja
Copy link
Contributor Author

@ArshSaja do you still intend to finish this PR? Seems this has gone stale over the past year.

We can draft this one. It needs more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants