Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes a bug where
_set_aeroDV_val
does not actually set the value. As far as I can tell, this bug/fix does not affect standard optimizations or much else in our codebase. However, the current code might cause problems if someone expects aero DVs to be updated when the AeroProblem is updated.The regression occured on this commit 1e2f389
I also thought this might be related to mdolab/adflow#208, but I don't think it is.
Expected time until merged
1-2 days
Type of change
Testing
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted