Fixed aeroDV value setting

[sseraj]

Purpose

This fixes a bug where _set_aeroDV_val does not actually set the value. As far as I can tell, this bug/fix does not affect standard optimizations or much else in our codebase. However, the current code might cause problems if someone expects aero DVs to be updated when the AeroProblem is updated.

The regression occured on this commit 1e2f389

I also thought this might be related to mdolab/adflow#208, but I don't think it is.

Expected time until merged

1-2 days

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[ewu63]

This is exactly the sort of thing that pylint catches.

[codecov]

Codecov Report

Merging #80 (c0e83f0) into main (308a554) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   29.30%   29.30%           
=======================================
  Files          25       25           
  Lines        2344     2344           
=======================================
  Hits          687      687           
  Misses       1657     1657           

Impacted Files	Coverage Δ
baseclasses/problems/pyAero_problem.py	18.48% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[marcomangano]

Lmao good catch