WIP: Seperates families and familyGroups
#34
Conversation
There was a problem hiding this comment.
I went through the changes but I need some more time to digest it... and understand our current code.
I see the point of this PR and makes sense to me, but I have some doubts (see my questions).
I feel we need a bit more documentation about the whole baseclasses magic, but we proabably want to deal with it in a separate PR.
baseclasses/pyAero_problem.py
Outdated
| except KeyError: | ||
| raise Error("The value must be given or set using the setActuatorVar routine") | ||
|
|
||
| # # the value of the BCData[familyGroup][key] maybe a dictionary of data for each patch |
There was a problem hiding this comment.
Is this still needed? I got the point codewise, but I am wondering if we need or want to allow this kind of nested dictionaries in the BCdata definition
baseclasses/pyAero_problem.py
Outdated
| def getBCData(self): | ||
| return self.bc_data | ||
|
|
||
| # def setBCArray(self, groupName, varName, dataArray, patch=None): |
There was a problem hiding this comment.
Is this needed? I guess this is related to the "nested" approach below, I am wondering for which cases having an array as an input would make sense
baseclasses/pyAero_problem.py
Outdated
| def getActuatorData(self): | ||
| return self.actuatorData | ||
|
|
||
| # def addBCDV(self, bc_var, value=None, lower=None, upper=None, scale=1.0, |
There was a problem hiding this comment.
When could this be useful?
baseclasses/pyAero_problem.py
Outdated
| else: | ||
| self.bcVarData[key, family] = value | ||
| setattr(self, key, value) |
There was a problem hiding this comment.
just a clarification on the "original" code: what vars would we be adding here? I assume there are previous checks on the key to be sure we are not adding a random name/var
baseclasses/pyAero_problem.py
Outdated
| self.size = value.size | ||
| else: | ||
| size = None | ||
| # TODO raise an error? |
There was a problem hiding this comment.
Makes sense... unless we want to "filter" these inputs before we instantiate the aeroDV container.
Are we using this size attribute anywhere yet? Definitely useful anyway
baseclasses/pyAero_problem.py
Outdated
| return aeroDvsDot, bcDvsDot, actDvsDot | ||
|
|
||
| def evalDVsSensBwd(self, aeroDvBar, BCDataBar, actDataBar): | ||
| """This internal furncion is used to convert the raw array output from |
There was a problem hiding this comment.
Two dumb questions here:
- Why the fwd and bwd function differ (i.e. why we have a different treatment for mach and altitude only for the bwd sens)?
- how are these functions going to be used, and how are we currently dealing with the sens raw data?
|
@joanibal what is the status of this PR? What bits are missing? |
|
@joanibal what is the state of this PR? |
|
It has been moved way to the back of my TODOs. Is there I way I can mark it inactive? |
ewu63
changed the title
families and familyGroupsfamilies and familyGroups
|
I added an app today actually, which is a status check that will be set to "in progress" if the PR title contains "WIP". I can set it to required which will prevent this from being merged. But in any case the draft PR should be fine, I think they just wanted to double check the status here. |
|
@joanibal, any updates on this PR? Do you have plans to work on this? |
This is a draft PR because I want to get feedback on the idea before adding the PRs for the other repos and totally polishing the code.
Purpose
Until now families and family groups have been used interchangeably by aerosolvers to refer to the list of surface families defined in the cgns mesh and those added by the user.
This is a problem if you want to iterate over the families on an aerosolver because the families defined by the user may contain surfaces already in another family.
It is because of this I propose separating the list of families and family groups in the
AeroSolverclass.The families dictionary will contain only the original families defined in the mesh file.
The family groups dictionary will contain all the original families, since each is a collection of a single family (itself), and all the additional family groups defined by the aerosolver and user.
for example:
This will make if feasible to do things like iterate over the families defined in the cgns mesh to return boundary condition information.
Type of change