-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface output for forces in lift and drag directions #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 13 13
Lines 4119 4119
=======================================
Hits 1690 1690
Misses 2429 2429 ☔ View full report in Codecov by Sentry. |
lamkina
previously approved these changes
Sep 13, 2024
I think bumping the minor version here makes sense. #362 is just adding tests so I don't think it needs to be factored into the version bump. |
marcomangano
approved these changes
Oct 21, 2024
lamkina
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds force coefficients per unit area projected in the lift and drag directions as surface output variables. Here is an example of the force in the drag direction for the MACH tutorial wing case:
It would be great if the reviewers could test this on their own cases.
Expected time until merged
2-3 weeks
Type of change
Testing
No tests, but I tried this on wing and full aircraft cases and the outputs made sense.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable