Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to several overset update routines #330
Updates to several overset update routines #330
Changes from 24 commits
af50a2d
4fec7ac
2605103
608b242
edbac73
132940d
99ad0a0
4de0910
1f4391a
90ed5ec
ac6ca79
4aff8a7
f99e537
d559f0e
75ffe84
738c138
28c4689
1bfbb80
09f1846
d0ccdc0
47df83b
9908c03
4b79221
261d6ae
c88f8c8
f8e1c0b
fc0a473
cce49b9
defb226
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should be checked before the loop as nothing is done but run the loop otherwise. This should also not be necessary if IDs are checked upfront.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved the check to cover the blocks after cellID is computed.