Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #28039 #14400

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fixing #28039 #14400

merged 1 commit into from
Jul 18, 2023

Conversation

charlyrmm92
Copy link
Contributor

@charlyrmm92 charlyrmm92 commented Jul 18, 2023 •
edited by Graywolf9
Loading

Description

Motivation

Additional details

Related issues and pull requests

Fixes mdn/content#28039

@charlyrmm92 charlyrmm92 requested a review from a team as a code owner July 18, 2023 19:57
@charlyrmm92 charlyrmm92 requested review from Jalkhov and removed request for a team July 18, 2023 19:57
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Jul 18, 2023
@charlyrmm92 charlyrmm92 mentioned this pull request Jul 18, 2023
Closed
@github-actions
Copy link
Contributor

Preview URLs

Flaws (5)

URL: /es/docs/Web/JavaScript/Reference/Functions/set
Title: setter
Flaw count: 5

  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /es/docs/Web/JavaScript/Referencia/Operadores/delete
    • Can use the English (en-US) link as a fallback
    • Can't resolve /es/docs/Web/JavaScript/Guide/Working_with_Objects#Defining_getters_and_setters
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

Graywolf9
Graywolf9 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias por tu tiempo y ayuda!

@Graywolf9 Graywolf9 merged commit ef62403 into mdn:main Jul 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@Jalkhov Jalkhov Awaiting requested review from Jalkhov Jalkhov is a code owner automatically assigned from mdn/yari-content-es

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setter - the word consr is shown instead of const
2 participants
@charlyrmm92 @Graywolf9