-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(css): Move CSS examples - Learn CSS, Building Blocks p1 #36607
Open
bsmth
wants to merge
7
commits into
mdn:main
Choose a base branch
from
bsmth:text-directions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+754
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Learn:CSS
Learning area CSS docs
size/l
[PR only] 501-1000 LoC changed
labels
Nov 1, 2024
estelle
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMostlyGTM!
Comment on lines
+243
to
+248
<p>A paragraph. Demonstrating Logical Properties in CSS.</p> | ||
</div> | ||
<div class="box logical"> | ||
<h2>Logical Properties</h2> | ||
<p>A paragraph. Demonstrating Logical Properties in CSS.</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
<p>A paragraph. Demonstrating Logical Properties in CSS.</p> | |
</div> | |
<div class="box logical"> | |
<h2>Logical Properties</h2> | |
<p>A paragraph. Demonstrating Logical Properties in CSS.</p> | |
</div> | |
<p>A paragraph demonstrating logical properties in CSS.</p> | |
</div> | |
<div class="box logical"> | |
<h2>Logical Properties</h2> | |
<p>A paragraph demonstrating logical properties in CSS.</p> | |
</div> |
@@ -39,15 +39,27 @@ The final selectors we will look at are called combinators, because they combine | |||
|
|||
## Descendant combinator | |||
|
|||
The **descendant combinator** — typically represented by a single space (" ") character — combines two selectors such that elements matched by the second selector are selected if they have an ancestor (parent, parent's parent, parent's parent's parent, etc.) element matching the first selector. Selectors that utilize a descendant combinator are called _descendant selectors_. | |||
The **descendant combinator** — typically represented by a single space (``) character — combines two selectors such that elements matched by the second selector are selected if they have an ancestor (parent, parent's parent, parent's parent's parent, etc.) element matching the first selector. Selectors that utilize a descendant combinator are called _descendant selectors_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The **descendant combinator** — typically represented by a single space (``) character — combines two selectors such that elements matched by the second selector are selected if they have an ancestor (parent, parent's parent, parent's parent's parent, etc.) element matching the first selector. Selectors that utilize a descendant combinator are called _descendant selectors_. | |
The **descendant combinator** — typically represented by a single space (` `) character — combines two selectors such that elements matched by the second selector are selected if they have an ancestor (parent, parent's parent, parent's parent's parent, etc.) element matching the first selector. Selectors that utilize a descendant combinator are called _descendant selectors_. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:
Motivation
Motivation is described in the project issue.
Related issues and pull requests