Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): Move CSS examples - Visual formatting model #36589

Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore(css): Move CSS examples - Visual formatting model #36589

merged 2 commits into from
Nov 1, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Oct 31, 2024

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/visual-formatting/anonymous-flex.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/visual-formatting/anonymous-block.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/visual-formatting/line-boxes.html", '100%', 720)}}
{{EmbedGHLiveSample("css-examples/display/multi-keyword/block-flow-root.html", '100%', 720)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner October 31, 2024 09:32
@bsmth bsmth requested review from chrisdavidmills and removed request for a team October 31, 2024 09:32
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-11-01 11:33:52)

chrisdavidmills
chrisdavidmills requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good @bsmth; just one comment for you to look at.

files/en-us/web/css/visual_formatting_model/index.md Outdated Show resolved Hide resolved
@bsmth bsmth requested a review from chrisdavidmills November 1, 2024 11:33
chrisdavidmills
chrisdavidmills approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works great! Thanks @bsmth.

@chrisdavidmills chrisdavidmills merged commit fb1a66a into mdn:main Nov 1, 2024
8 checks passed
@bsmth bsmth deleted the css-visual-formatting branch November 1, 2024 12:16
@bsmth
Copy link
Member Author

bsmth commented Nov 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @chrisdavidmills