-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example of measuring prerendering activations #36526
Conversation
We found some web developers attempting to use the pattern for delaying code during prerendering for tracking prerendering activations, which does not work well. Add an explicit example of how to do the latter.
Preview URLs (comment last updated: 2024-11-01 11:47:10) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-owner LGTM
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@domenic Aside from the comments this looks good to me. Do we also need an update to https://developer.mozilla.org/en-US/docs/Web/API/Document/prerendering for this case (it has the same example). |
Co-authored-by: Hamish Willee <[email protected]>
Co-authored-by: Hamish Willee <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Good call. At first I thought we might be fine since that page has a variety of examples that guide you in the right direction, but I think being more explicit and including the new example as well is better. I've attempted to do so; thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domenic Thank you. I have approved. Is there anyone else you'd like a review from before merge?
No, we should be good! Thank you!! |
Thanks, all, merging shortly |
Description
Add an explicit example of how to measure prerendering activations.
Motivation
We found some web developers attempting to use the pattern for delaying code during prerendering for measuring prerendering activations, which does not work well.
Additional details
None
Related issues and pull requests
None