Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #29639 & create page for HTMLInputElement.cancel_event #36439

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Revert #29639 & create page for HTMLInputElement.cancel_event #36439

merged 3 commits into from
Oct 29, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Oct 22, 2024 •
edited
Loading

Description

Revert ":bug: Add missing cancel event to <input type=file> (#29639)".

This reverts commit 0900a56.

Also add new page for HTMLInputElement.cancel_event.

Motivation

Additional details

Related issues and pull requests

Fixes #31014

Fixes #31910

Closes mdn/browser-compat-data#21585

@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Preview URLs (7 pages)
Flaws (4)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLInputElement
Title: HTMLInputElement
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/align does not exist
    • /en-US/docs/Web/API/HTMLInputElement/dirName does not exist
    • /en-US/docs/Web/API/HTMLInputElement/incremental does not exist
    • /en-US/docs/Web/API/HTMLInputElement/useMap does not exist

(comment last updated: 2024-10-29 19:47:20)

@skyclouds2001 skyclouds2001 changed the title Revert #29639 & create page for HTMLInputElement.cancwl_event Revert #29639 & create page for HTMLInputElement.cancel_event Oct 22, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Oct 22, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 22, 2024 11:49
@skyclouds2001 skyclouds2001 requested review from a team as code owners October 22, 2024 11:49
@skyclouds2001 skyclouds2001 requested review from sideshowbarker and estelle and removed request for a team October 22, 2024 11:49
@sideshowbarker sideshowbarker removed their request for review October 24, 2024 02:58
Josh-Cena
Josh-Cena approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

files/en-us/web/api/htmlinputelement/cancel_event/index.md Outdated Show resolved Hide resolved
estelle
estelle approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit d2421d2 into mdn:main Oct 29, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the cancel branch October 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
3 participants
@skyclouds2001 @estelle @Josh-Cena