-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
35381 angular update #35632
base: main
Are you sure you want to change the base?
35381 angular update #35632
Conversation
Thanks for making the changes! I will take a look in the coming days. |
I haven't forgotten about this one, BTW, I have some other work that's top of my list for the moment. I will be getting back to this shortly. Thanks for the patience. |
…1-angular-update
…1-angular-update
Changelog, for convenience: https://github.com/angular/angular/releases/tag/18.0.0 |
...s/learn/tools_and_testing/client-side_javascript_frameworks/angular_getting_started/index.md
Outdated
Show resolved
Hide resolved
...s/learn/tools_and_testing/client-side_javascript_frameworks/angular_getting_started/index.md
Show resolved
Hide resolved
Thanks for the improvements, the only issue I see is that this PR is targeting the |
@@ -117,25 +121,28 @@ Angular uses `\{{item.description}}` to retrieve the description of the current | |||
The next section explains how components share data in detail. | |||
|
|||
The next two buttons for editing and deleting the current item are within a `<div>`. | |||
On this `<div>` is an `*ngIf`, a built-in Angular directive that you can use to dynamically change the structure of the DOM. | |||
This `*ngIf` means that if `editable` is `false`, this `<div>` is in the DOM. If `editable` is `true`, Angular removes this `<div>` from the DOM. | |||
On this `<div>` is an `@if`, a built-in Angular directive that you can use to dynamically change the structure of the DOM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're updating these (@if
and @for
), we need to change the prose because;
NgIf
= "A structural directive that conditionally includes a template based on the value of an expression"
@if
= "block conditionally displays its content when its condition expression is truthy"
I think the @if
block is more appropriate for the code, and is an improvement, but we need to change "Angular directive(s)" to "block syntax(es)" or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Angular docs, those are grouped as Control Flows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok super, so I think we can refer to them as 'control flow blocks'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ragul1697 do you want to make the changes or should I edit this branch / make suggestions on this PR? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bsmth, You can make suggestions on this PR. I will update the branch following your suggestions. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK super, assigning myself
Fixes #35381 - Updating the tutorial for Angular to latest version