Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35381 angular update #35632

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

ragul1697
Copy link
Contributor

@ragul1697 ragul1697 commented Aug 29, 2024

Fixes #35381 - Updating the tutorial for Angular to latest version

@ragul1697 ragul1697 requested a review from a team as a code owner August 29, 2024 14:39
@ragul1697 ragul1697 requested review from hamishwillee and removed request for a team August 29, 2024 14:39
@github-actions github-actions bot added Content:Glossary Glossary entries Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees size/m [PR only] 51-500 LoC changed labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Preview URLs (6 pages)
External URLs (29)

URL: /en-US/docs/Glossary/Router
Title: Router


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Angular_getting_started
Title: Getting started with Angular


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Angular_item_component
Title: Creating an item component


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Main_features
Title: Framework main features


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Angular_todo_list_beginning
Title: Beginning our Angular todo list app


URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Angular_building
Title: Building Angular applications and further resources

(comment last updated: 2024-11-01 05:03:26)

@hamishwillee hamishwillee removed their request for review August 30, 2024 01:39
@Josh-Cena Josh-Cena requested a review from bsmth August 30, 2024 01:55
@bsmth
Copy link
Member

bsmth commented Aug 30, 2024

Thanks for making the changes! I will take a look in the coming days.

@bsmth
Copy link
Member

bsmth commented Sep 20, 2024

I haven't forgotten about this one, BTW, I have some other work that's top of my list for the moment. I will be getting back to this shortly. Thanks for the patience.

@bsmth
Copy link
Member

bsmth commented Oct 28, 2024

Changelog, for convenience: https://github.com/angular/angular/releases/tag/18.0.0

@bsmth
Copy link
Member

bsmth commented Oct 28, 2024

Thanks for the improvements, the only issue I see is that this PR is targeting the @next version which may change, so this concerns the 'structural directives' syntax: https://angular.dev/guide/directives#built-in-structural-directives

@@ -117,25 +121,28 @@ Angular uses `\{{item.description}}` to retrieve the description of the current
The next section explains how components share data in detail.

The next two buttons for editing and deleting the current item are within a `<div>`.
On this `<div>` is an `*ngIf`, a built-in Angular directive that you can use to dynamically change the structure of the DOM.
This `*ngIf` means that if `editable` is `false`, this `<div>` is in the DOM. If `editable` is `true`, Angular removes this `<div>` from the DOM.
On this `<div>` is an `@if`, a built-in Angular directive that you can use to dynamically change the structure of the DOM.
Copy link
Member

@bsmth bsmth Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're updating these (@if and @for), we need to change the prose because;

NgIf = "A structural directive that conditionally includes a template based on the value of an expression"

@if = "block conditionally displays its content when its condition expression is truthy"

I think the @if block is more appropriate for the code, and is an improvement, but we need to change "Angular directive(s)" to "block syntax(es)" or similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Angular docs, those are grouped as Control Flows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok super, so I think we can refer to them as 'control flow blocks'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ragul1697 do you want to make the changes or should I edit this branch / make suggestions on this PR? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bsmth, You can make suggestions on this PR. I will update the branch following your suggestions. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK super, assigning myself

@bsmth bsmth self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Angular] Update Angular guide for v18
2 participants