Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): improve :defined pseudo-class example #35371

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix(css): improve :defined pseudo-class example #35371

merged 4 commits into from
Sep 17, 2024

Conversation

OnkarRuikar
Copy link
Contributor

The PR

  • fixes the typo
  • converts the example to a local live sample
  • loads the custom element on click of a button
  • instead of display:none uses a overlay to hide the element

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner August 8, 2024 12:55
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team August 8, 2024 12:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-09-17 08:47:25)

chrisdavidmills
chrisdavidmills requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved, nice work @OnkarRuikar. I had a few comments for you to look at, but nothing major.

files/en-us/web/css/_colon_defined/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_defined/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_defined/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_defined/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_defined/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_defined/index.md Show resolved Hide resolved
@OnkarRuikar
Copy link
Contributor Author

@chrisdavidmills, thank you for the suggestions!

When the translated content incorporates this change, should we delete https://github.com/mdn/web-components-examples/tree/main/defined-pseudo-class ?

@Josh-Cena Josh-Cena mentioned this pull request Aug 10, 2024
Closed
@OnkarRuikar
Copy link
Contributor Author

ping @chrisdavidmills

chrisdavidmills
chrisdavidmills approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @OnkarRuikar, let's get it merged. Sorry about the delay.

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills, thank you for the suggestions!

When the translated content incorporates this change, should we delete https://github.com/mdn/web-components-examples/tree/main/defined-pseudo-class ?

Yes, I think so too.

@chrisdavidmills chrisdavidmills merged commit 415caa6 into mdn:main Sep 17, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_defined branch September 17, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS :defined pseudo-class: Improve example and fix typo
2 participants
@OnkarRuikar @chrisdavidmills