Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HTTP): Refresh 5XX response pages #35361

Merged
merged 15 commits into from
Aug 30, 2024
Merged

feat(HTTP): Refresh 5XX response pages #35361

merged 15 commits into from
Aug 30, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Aug 7, 2024 •
edited
Loading

Description

This PR refreshes the 5XX HTTP status response code pages.

Motivation

Keeping content up-to-date and useful.

additions:

  • Examples in HTTP format
  • See also links to HTTP status codes page
  • Unify formatting with current conventions (e.g., ## Example to ## Examples with subsections)

Related issues and pull requests:

Fixes #35565

@bsmth bsmth requested a review from a team as a code owner August 7, 2024 16:27
@bsmth bsmth requested review from hamishwillee and removed request for a team August 7, 2024 16:27
@github-actions github-actions bot added Content:HTTP HTTP docs size/m [PR only] 51-500 LoC changed labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Preview URLs (11 pages)
External URLs (4)

URL: /en-US/docs/Web/HTTP/Status/501
Title: 501 Not Implemented

URL: /en-US/docs/Web/HTTP/Status/506
Title: 506 Variant Also Negotiates

(comment last updated: 2024-08-30 09:01:03)

@bsmth bsmth mentioned this pull request Aug 8, 2024
Merged
4 tasks
@hamishwillee
Copy link
Collaborator

A bunch of mostly nits.

@Josh-Cena Josh-Cena linked an issue Aug 23, 2024 that may be closed by this pull request
503 error cause #35565
Closed
@hamishwillee
Copy link
Collaborator

@bsmth Just nits now. Approved so you can self-merge after looking at them.

@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Aug 30, 2024
@bsmth
Copy link
Member Author

bsmth commented Aug 30, 2024

@bsmth Just nits now. Approved so you can self-merge after looking at them.

Thanks a lot, applied your suggestions and added some more details about server "maintenance mode" cases for 503s.

@bsmth bsmth merged commit f584f1b into mdn:main Aug 30, 2024
8 checks passed
@bsmth bsmth deleted the http-5xx-statuses branch August 30, 2024 09:10
@bsmth bsmth mentioned this pull request Sep 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
Content:HTTP HTTP docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

503 error cause
3 participants
@bsmth @hamishwillee @Josh-Cena