Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect description in WebExtensions #35351

Merged
merged 4 commits into from
Aug 8, 2024
Merged

fix: incorrect description in WebExtensions #35351

merged 4 commits into from
Aug 8, 2024

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented Aug 7, 2024 •
edited
Loading 

-  - : `object`. An object containing either `imageData` or `path` properties, and optionally a `tabId` property.
+  - : `object`. An object containing either `imageData` or `path` properties, and optionally `tabId` and/or `windowId` properties.

@PassionPenguin PassionPenguin requested a review from a team as a code owner August 7, 2024 04:22
@PassionPenguin PassionPenguin requested review from Rob--W and removed request for a team August 7, 2024 04:22
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-08-08 02:43:58)

Rob--W
Rob--W approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me from the technical perspective.

@rebloor Does the language look good to you too?

@Rob--W Rob--W requested a review from rebloor August 7, 2024 08:48
@rebloor rebloor merged commit ad9a263 into mdn:main Aug 8, 2024
8 checks passed
@rebloor
Copy link
Contributor

rebloor commented Aug 8, 2024

Thanks @PassionPenguin

@PassionPenguin PassionPenguin deleted the patch-2 branch August 9, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

@rebloor rebloor Awaiting requested review from rebloor

Assignees
No one assigned
Labels
Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PassionPenguin @rebloor @Rob--W