-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redirected links, part 8 #35338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
requested review from
fred-wang,
wbamberg,
hamishwillee and
estelle
and removed request for
a team
August 6, 2024 16:04
github-actions
bot
added
Content:CSS
Cascading Style Sheets docs
Content:HTML
Hypertext Markup Language docs
Content:WebAPI
Web API docs
Content:JS
JavaScript docs
Content:Learn
Learning area docs
Content:Other
Any docs not covered by another "Content:" label
Content:HTTP
HTTP docs
Content:Accessibility
Accessibility docs
Content:SVG
SVG docs
Content:Media
Media docs
Content:Learn:Express
Learning area Express docs
Content:wasm
WebAssembly docs
Content:MathML
MathML docs
Content:Glossary
Glossary entries
labels
Aug 6, 2024
github-actions
bot
added
Content:Security
Security docs
Content:Learn:Client-side
Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees
Content:Learn:JavaScript
Learning area JavaScript docs
Content:Meta
Content in the meta docs
Content:Learn:CSS
Learning area CSS docs
Content:Learn:HTML
Learning area HTML docs
Content:Learn:Accessibility
Accessibility documentation in the Learn Area
Content:Learn:Forms
Learning area Forms docs
Content:Learn:Cross-Browser-Testing
Learning area Cross-Browser-Testing docs
Content:PWA
Progressive Web Apps content
size/m
[PR only] 51-500 LoC changed
labels
Aug 6, 2024
Josh-Cena
force-pushed
the
redirect-links-8
branch
from
August 6, 2024 21:13
efee3f0
to
6dc838a
Compare
bsmth
reviewed
Aug 7, 2024
bsmth
reviewed
Aug 7, 2024
bsmth
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Josh. LGTM with two comments.
Co-authored-by: Brian Thomas Smith <[email protected]>
This pull request has merge conflicts that must be resolved before it can be merged. |
Josh-Cena
commented
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:Accessibility
Accessibility docs
Content:CSS
Cascading Style Sheets docs
Content:Games
Games docs
Content:Glossary
Glossary entries
Content:HTML
Hypertext Markup Language docs
Content:HTTP
HTTP docs
Content:JS
JavaScript docs
Content:Learn:Accessibility
Accessibility documentation in the Learn Area
Content:Learn:Client-side
Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees
Content:Learn:Cross-Browser-Testing
Learning area Cross-Browser-Testing docs
Content:Learn:CSS
Learning area CSS docs
Content:Learn:Django
Learning area Django docs
Content:Learn:Express
Learning area Express docs
Content:Learn:Forms
Learning area Forms docs
Content:Learn:HTML
Learning area HTML docs
Content:Learn:JavaScript
Learning area JavaScript docs
Content:Learn
Learning area docs
Content:MathML
MathML docs
Content:Media
Media docs
Content:Meta
Content in the meta docs
Content:Other
Any docs not covered by another "Content:" label
Content:Performance
Web performance docs
Content:PWA
Progressive Web Apps content
Content:Security
Security docs
Content:SVG
SVG docs
Content:wasm
WebAssembly docs
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My script failed to pick up some redirected links because the TLD is missing a trailing slash. I added the trailing slash since it's also technically a "redirect".